Repository navigation
fix(cmd): Skip failed entries when getting certificates - #542
Merged
Merged
Conversation
A GET for an unknown name still returns an entry for it, carrying an error status and no state. Since b8d5a53 those entries were no longer filtered, so the empty state failed to parse and the lookup errored with "unknown certificate state" rather than reporting the reference as not found. Filter on the per-item response status like every other resource does. Pending certificates still report success here, so they stay visible; the comment that said otherwise conflated response status with certificate state. Signed-off-by: Justin Chadwell <justin@unikraft.com>
The certificate case has regressed before: a lookup for an unknown name surfaced the mirror error from the parent commit rather than a not-found. Cover it, and the instance equivalent, with nothing but a name that does not exist. Signed-off-by: Justin Chadwell <justin@unikraft.com>
jedevc
force-pushed
the
crt-get-status-filter
branch
from
October 9, 2026 13:54
931d9c3 to
d4b4b5c
Compare
craciunoiuc
approved these changes
Oct 9, 2026
craciunoiuc
left a comment
craciunoiuc
left a comment
Contributor
There was a problem hiding this comment.
All good here. Thanks!
Reviewed-by: Cezar Craciunoiu <cezar.craciunoiu@unikraft.com>
Approved-by: Cezar Craciunoiu <cezar.craciunoiu@unikraft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
unikraft crt get <missing>currently fails withcould not mirror certificate data: field State: failed to set field value: unknown certificate state: ""instead of a not-found. The not-found entry in the API response has no state, and since b8d5a53 dropped the per-item status filter it was being parsed as a certificate.Checked against the platform source: the status handler only emits
stateinside the success branch and the lookup condition is justukp_db_is_active_ref, so pending (and error-state) certificates still come back withstatus: successand remain visible after this.