Repository navigation
chore: Promote prod-staging to prod-stable - #541
Merged
Merged
Conversation
lipgloss/v2/compat asks the console for its background at init. On Windows with stdin redirected, it reads with a reader that cannot time out, so a process that gets no reply waits forever. Replace lipgloss with unikraft-cloud/lipgloss, which has the fix from charmbracelet/lipgloss#746, as the replace in x does not reach the CLI. Signed-off-by: Cezar Craciunoiu <cezar@unikraft.io>
Reviewed-by: Abdallah Abedraba <abdallah@unikraft.com> Approved-by: Abdallah Abedraba <abdallah@unikraft.com>
The default rootfs format is picked by checking every platform for an EROFS feature flag, and a build with no runtime has no kernel to carry those flags, so it always fell through to cpio. DefaultRootfsFormat now takes the build options and returns erofs outright when nothing supplies a kernel; with a runtime it keeps the per-platform feature check. The empty-platform case is dropped rather than kept, as BuildRootfs already rejects it before this is reached. Signed-off-by: Justin Chadwell <justin@unikraft.com>
Reviewed-by: Cezar Craciunoiu <cezar.craciunoiu@unikraft.com> Approved-by: Cezar Craciunoiu <cezar.craciunoiu@unikraft.com>
danielvallance
marked this pull request as ready for review
October 8, 2026 16:34
jedevc
approved these changes
Oct 8, 2026
jedevc
left a comment
jedevc
left a comment
Member
There was a problem hiding this comment.
Reviewed-by: Justin Chadwell <justin@unikraft.com>
Approved-by: Justin Chadwell <justin@unikraft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.