Skip to content

Fix five messages with a broken or missing placeholder (bn-BD, ga-ES, mn-MN, ru-RU, uz-UZ) - #4556

Open
Na5co wants to merge 1 commit into
umami-software:masterfrom
Na5co:fix-message-placeholders
Open

Na5co wants to merge 1 commit into
umami-software:masterfrom
Na5co:fix-message-placeholders

Conversation

@Na5co

@Na5co Na5co commented Sep 21, 2026

Copy link
Copy Markdown

Five strings in public/intl/messages don't match the placeholders in en-US.json, so they either render the braces literally or, for an unknown ICU argument, fail to format at all:

  • bn-BD message.visitor-log: the placeholder itself was translated, {ব্রাউজার}<b>{browser}</b>
  • mn-MN and uz-UZ message.two-factor-locked-message: [[9000]]] (looks like a machine translation artifact) → {time}
  • ru-RU message.reset-website: hardcoded RESET{confirmation}, so it matches whatever the confirmation word is
  • ga-ES label.reset-website: the label contained the whole confirmation sentence with {confirmation} in it; replaced with a short label, Restablecer sitio web. This is the one line where wording changed, happy to adjust if a Galician speaker prefers something else.

km-KH has the same label problem (label.reset-website holds the message text) but I don't know Khmer well enough to write the label, so I left it.

Files keep their formatting; one line changed per file.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

@vercel

vercel Bot commented Sep 21, 2026

Copy link
Copy Markdown

@Na5co is attempting to deploy a commit to the Umami Software Team on Vercel.

A member of the Team first needs to authorize it.

@greptile-apps

greptile-apps Bot commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge; every changed translation now matches its canonical placeholder contract and relevant call sites.

Summary

This PR corrects malformed or misplaced localization placeholders across five locale files.

  • Restores the Bengali browser argument and expected rich-text markup.
  • Restores the Mongolian and Uzbek lockout-time arguments.
  • Replaces the Russian hardcoded confirmation value with the canonical argument.
  • Replaces the Galician reset label’s misplaced confirmation sentence with a concise label.

Reviews (1) · Last reviewed commit: "Fix five messages with a broken or missi..."

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant