Skip to content

Accept normalized CLA signature comments - #104

Merged
glenn-jocher merged 1 commit into
mainfrom
cla-signature-gate-20260828
Aug 28, 2026
Merged

Accept normalized CLA signature comments#104
glenn-jocher merged 1 commit into
mainfrom
cla-signature-gate-20260828

Conversation

@glenn-jocher

@glenn-jocher glenn-jocher commented Aug 28, 2026

Copy link
Copy Markdown
Member

Valid CLA signature comments with trailing whitespace or surrounding Markdown currently never reach the normalized action matcher because the workflow gate requires exact equality.

This makes only the signature gate permissive. The recheck command remains exact, and the action still decides whether a single normalized line is a valid signature, so quoted or instructional text does not sign the CLA.

Related matcher fix: ultralytics/actions#894

Validation:

  • actionlint .github/workflows/cla.yml
  • npx prettier@3.8.5 --check .github/workflows/cla.yml

🛠️ PR Summary

Made with ❤️ by Ultralytics Actions

🌟 Summary

Updates the CLA workflow to pass comments containing the signature phrase to the existing normalized matcher, allowing valid signatures with surrounding whitespace or Markdown.

📊 Key Changes

  • Replaces exact equality for CLA signature comments with a contains() check in .github/workflows/cla.yml.
  • Keeps the recheck command gated by exact equality.
  • Leaves final signature validation to the action’s normalized single-line matcher, so quoted or instructional text does not sign the CLA.

🎯 Purpose & Impact

  • CLA comments with trailing whitespace or surrounding Markdown can now reach the matcher and be evaluated.
  • The workflow’s recheck behavior remains unchanged.

@UltralyticsAssistant UltralyticsAssistant added bug Something isn't working devops GitHub Devops or MLops fixed Bug has been resolved labels Aug 28, 2026
@UltralyticsAssistant

Copy link
Copy Markdown
Member

👋 Hello @glenn-jocher, thank you for submitting a ultralytics/template 🚀 PR! This automated message confirms your contribution was received, and an Ultralytics engineer will assist with the review. To ensure a seamless integration of your work, please review the following checklist:

  • Define a Purpose: Clearly explain the purpose of your fix or feature in your PR description, and link to any relevant issues. Ensure your commit messages are clear, concise, and adhere to the project's conventions.
  • Synchronize with Source: Confirm your PR is synchronized with the ultralytics/template main branch. If it's behind, update it by clicking the 'Update branch' button or by running git pull and git merge main locally.
  • Ensure CI Checks Pass: Verify all Ultralytics Continuous Integration (CI) checks are passing. If any checks fail, please address the issues.
  • Update Documentation: Update the relevant documentation for any new or modified features.
  • Add Tests: If applicable, include or update tests to cover your changes, and confirm that all tests are passing.
  • Sign the CLA: Please ensure you have signed our Contributor License Agreement if this is your first Ultralytics PR by writing "I have read the CLA Document and I sign the CLA" in a new message.
  • Minimize Changes: Limit your changes to the minimum necessary for your bug fix or feature addition. "It is not daily increase but daily decrease, hack away the unessential. The closer to the source, the less wastage there is." — Bruce Lee

For more guidance, please refer to our Contributing Guide. Don't hesitate to leave a comment if you have any questions. Thank you for contributing to Ultralytics! 🚀

@codecov

codecov Bot commented Aug 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@UltralyticsAssistant

Copy link
Copy Markdown
Member

👋 Hello @glenn-jocher, thank you for submitting a ultralytics/template 🚀 PR! This automated message confirms your contribution was received, and an Ultralytics engineer will assist with the review. To ensure a seamless integration of your work, please review the following checklist:

  • Define a Purpose: Clearly explain the purpose of your fix or feature in your PR description, and link to any relevant issues. Ensure your commit messages are clear, concise, and adhere to the project's conventions.
  • Synchronize with Source: Confirm your PR is synchronized with the ultralytics/template main branch. If it's behind, update it by clicking the 'Update branch' button or by running git pull and git merge main locally.
  • Ensure CI Checks Pass: Verify all Ultralytics Continuous Integration (CI) checks are passing. If any checks fail, please address the issues.
  • Update Documentation: Update the relevant documentation for any new or modified features.
  • Add Tests: If applicable, include or update tests to cover your changes, and confirm that all tests are passing.
  • Sign the CLA: Please ensure you have signed our Contributor License Agreement if this is your first Ultralytics PR by writing "I have read the CLA Document and I sign the CLA" in a new message.
  • Minimize Changes: Limit your changes to the minimum necessary for your bug fix or feature addition. "It is not daily increase but daily decrease, hack away the unessential. The closer to the source, the less wastage there is." — Bruce Lee

For more guidance, please refer to our Contributing Guide. Don't hesitate to leave a comment if you have any questions. Thank you for contributing to Ultralytics! 🚀

@UltralyticsAssistant UltralyticsAssistant left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 PR Review

Made with ❤️ by Ultralytics Actions

LGTM. The workflow gate now admits signature comments containing trailing whitespace or supported surrounding Markdown while preserving exact matching for recheck; the action remains responsible for validating the normalized signature line.

@glenn-jocher
glenn-jocher merged commit 600b40c into main Aug 28, 2026
16 checks passed
@glenn-jocher
glenn-jocher deleted the cla-signature-gate-20260828 branch August 28, 2026 10:50
@UltralyticsAssistant

Copy link
Copy Markdown
Member

🎉 PR #104 was successfully merged—thank you, @glenn-jocher!

“Great things are done by a series of small things brought together.” — Vincent van Gogh

This focused workflow update lets CLA comments with surrounding whitespace or Markdown reach the normalized matcher while preserving exact-match gating for recheck and final signature validation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working devops GitHub Devops or MLops fixed Bug has been resolved

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants