Accept normalized CLA signature comments - #104
Conversation
|
👋 Hello @glenn-jocher, thank you for submitting a
For more guidance, please refer to our Contributing Guide. Don't hesitate to leave a comment if you have any questions. Thank you for contributing to Ultralytics! 🚀 |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
👋 Hello @glenn-jocher, thank you for submitting a
For more guidance, please refer to our Contributing Guide. Don't hesitate to leave a comment if you have any questions. Thank you for contributing to Ultralytics! 🚀 |
UltralyticsAssistant
left a comment
There was a problem hiding this comment.
🔍 PR Review
Made with ❤️ by Ultralytics Actions
LGTM. The workflow gate now admits signature comments containing trailing whitespace or supported surrounding Markdown while preserving exact matching for recheck; the action remains responsible for validating the normalized signature line.
|
🎉 PR #104 was successfully merged—thank you, @glenn-jocher!
This focused workflow update lets CLA comments with surrounding whitespace or Markdown reach the normalized matcher while preserving exact-match gating for |
Valid CLA signature comments with trailing whitespace or surrounding Markdown currently never reach the normalized action matcher because the workflow gate requires exact equality.
This makes only the signature gate permissive. The
recheckcommand remains exact, and the action still decides whether a single normalized line is a valid signature, so quoted or instructional text does not sign the CLA.Related matcher fix: ultralytics/actions#894
Validation:
actionlint .github/workflows/cla.ymlnpx prettier@3.8.5 --check .github/workflows/cla.yml🛠️ PR Summary
Made with ❤️ by Ultralytics Actions
🌟 Summary
Updates the CLA workflow to pass comments containing the signature phrase to the existing normalized matcher, allowing valid signatures with surrounding whitespace or Markdown.
📊 Key Changes
contains()check in.github/workflows/cla.yml.recheckcommand gated by exact equality.🎯 Purpose & Impact
recheckbehavior remains unchanged.