Skip to content

Fieldset for cross-field validation - #723

Open
kitttang wants to merge 6 commits into
v2from
one-of
Open

kitttang wants to merge 6 commits into
v2from
one-of

Conversation

@kitttang

Copy link
Copy Markdown
Collaborator

Fieldset

  • New component based on ContactDetailsCollection
  • Can put other components inside it and they will maintain their individual validation
  • Validation set up for a minimum required number of fields
  • Extendible for other types of validation, and at the same time
  • Helper method to change the path and href of errors to the first child component of the fieldset as browsers will only scroll to an input field

Telephone number field

  • given textBaseFieldCustomisations in the condition operators so it is now possible to check it it's empty

tyler-ukhsa
tyler-ukhsa previously approved these changes Sep 15, 2026
},
"type": "TelephoneNumberField",
"title": "Phone number",
"hint": "For example For example, ‘01632 960 001, 07700 900 982 or +44 808 157 0192’"

@tyler-ukhsa tyler-ukhsa Sep 15, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For example is repeated here

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of interest
Do we have a concept of "Default hint" on fields?
A standardized approved default that prevents duplication?

@kitttang
kitttang marked this pull request as ready for review September 15, 2026 10:39
@kitttang
kitttang requested a review from a team as a code owner September 15, 2026 10:39
schema?: {};
}

export type ValidationRule = MinimumRequired;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused export?
Or if used, ambiguous naming?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants