Repository navigation
seat: handle failed session create in switch-to-user (#431) - #491
Open
Franklin-Qi wants to merge 1 commit into
Open
Franklin-Qi wants to merge 1 commit into
Franklin-Qi wants to merge 1 commit into
Conversation
create_user_session can return NULL (unknown user / missing session). Guard that path and honor an explicit session name from dm-tool. Closes: ubuntu#431
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
seat_switch_to_userusedcreate_user_sessionwithout a NULL check, causing GLib assertions when the session cannot be created (e.g. unknown user / missing session config).dm-tool switch-to-user USER [SESSION].test-switch-to-user-unknownregression coverage.Closes: #431