Repository navigation
Update minimatch to 11 through npm overrides - #43349
Closed
julien-deramond wants to merge 1 commit into
Closed
julien-deramond wants to merge 1 commit into
julien-deramond wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
✅ Deploy Preview for twbs-bootstrap ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dependabot reports GHSA-g3hv-75wg-m249 on
minimatch(moderate, denial of service through**/..patterns), affecting every version from 7.0.0 up to 11.0.1. Seven copies in our dev tree were affected (9.0.9, 10.2.5, 10.2.6), and the fix only exists in minimatch 11, a major release that none of their parents accept yet. This moves them all to 11.0.7.eslint-plugin-import-x4.18.1 already accepts minimatch 11, so it gets a normal bump. ESLint (with@eslint/config-array),@typescript-eslint/typescript-estree,markdownlint-cliandnodemonstill declare^10, so they get scoped npm overrides, the same approach asre2js. They only callminimatch(),new Minimatch()with.match(), and.pattern, which 11 keeps. Version 11 removesmakeRe(),Minimatch#regexp,ASTandmatchOne(), and none of them use those.jasmine is the exception. Every
globversion it allows (10 to 13) needs minimatch 10 or lower and readsMinimatch#setasRegExps, which 11 changes. So jasmine's ownglobis overridden to 14.0.4, which depends on minimatch 11. The rootminimatch3.1.5 (forglob7) isn't in the affected range and stays as it is.The overrides can go once ESLint, markdownlint-cli, nodemon and jasmine accept minimatch 11 themselves.
Notes: what was checked, and how to check it again
Each check was run on
mainand on this branch, with the same results:eslint --report-unused-disable-directives .markdownlint(docs-mdx,docs-md)npm run css-test(jasmine,glob14)npm run lockfile-lintnodemon's matcher was checked directly on minimatch 11. With
scss/**/*and thescssextension, it keepsscss/_root.scssand leaves outjs/src/x.jsandscss/a.css.The JS tests, the docs build and the
watch-*scripts weren't run locally. CI covers the first two.How to check it again
🤖 Generated with Claude Code