Skip to content

fix(drawer): keep open drawers on-screen in RTL #43345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ump45nose wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(drawer): keep open drawers on-screen in RTL #43345

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions scss/_drawer.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,15 +143,20 @@ $drawer-backdrop-tokens: defaults(
&:where(.drawer-start) {
transform: translateX(calc(-100% - var(--drawer-inset)));

:root:dir(rtl) & {
// Wrap :root:dir(rtl) in :where() so this rule stays at the same
// specificity as the LTR off-canvas transform. A bare :root:dir(rtl)
// ancestor out-specs `[open] { transform: none }`, which keeps the
// drawer translated off-screen in RTL while the backdrop still shows.
// See https://github.com/twbs/bootstrap/issues/43340
:where(:root:dir(rtl)) & {
transform: translateX(calc(100% + var(--drawer-inset)));
}
}

&:where(.drawer-end) {
transform: translateX(calc(100% + var(--drawer-inset)));

:root:dir(rtl) & {
:where(:root:dir(rtl)) & {
transform: translateX(calc(-100% - var(--drawer-inset)));
}
}
Expand Down
Loading