Repository navigation
Conversation
…bs#43333) Signed-off-by: Aryan Sachin <aryansachinixd@gmail.com>
Aryan9891
added a commit
to Aryan9891/Aryan9891
that referenced
this pull request
Nov 10, 2026
Signed-off-by: Aryan Sachin <aryansachinixd@gmail.com>
julien-deramond
self-requested a review
November 11, 2026 09:29
julien-deramond
requested changes
Nov 11, 2026
julien-deramond
left a comment
Member
There was a problem hiding this comment.
Thanks for the PR, @Aryan9891. The direction is right, but it isn’t ready yet:
- It’s incomplete.
clipis still used in other places in the codebase, so the compiled CSS still contains it and Stylelint still flags it. #43333 wouldn’t be fixed by this PR alone. - No testing is shown. The description says accessibility and visual hiding are kept “across all modern browser engines”, but doesn’t say what was checked. This affects every visually hidden element, so please list the cases you tested, in which browsers, and include evidence such as screenshots, or anything that can help ease the review and reduce the manual tests I'd have to do.
- The history isn’t covered.
clip-pathwas in this mixin before and was removed. Please check why, and confirm the reason no longer applies.
Once these are addressed, I’ll take another look.
…wbs#43333) Signed-off-by: Aryan Sachin <aryansachinixd@gmail.com>
Contributor
Author
|
Thanks for the thorough review and guidance, @julien-deramond! I have addressed all three points in commit 2388825: 1. Complete Removal of clip Across the Entire CodebaseIn addition to scss/mixins/_visually-hidden.scss, all remaining occurrences of clip: rect(0, 0, 0, 0) have been converted to clip-path: inset(50%):
git grep "clip: rect(" now returns 0 matches across all SCSS, CSS, and examples. Running stylelint "**/*.{css,scss}" and the full 2. Testing Matrix & Cross-Engine Verification
3. Historical Context: Why clip-path Was Removed & Why That Reason No Longer Applies
All checks are passing locally ( |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR replaces the deprecated CSS
clip: rect(0, 0, 0, 0) !important;property inscss/mixins/_visually-hidden.scsswith the modern standardclip-path: inset(50%) !important;.Motivation & Context
In Bootstrap v6 (
mainbranch), legacy browsers requiringclipare no longer targeted. As reported in #43333, theclipCSS property is officially deprecated (per MDN CSS clip reference) and flags violations whenproperty-no-deprecatedis enforced.Modernizing to
clip-path: inset(50%) !important;retains complete accessibility and visual-hiding semantics across all modern browser engines while adhering to current web standards.Type of changes
Checklist
npm run lint)Related issues
Closes #43333