Repository navigation
fix(drawer): prevent TypeError when toggling with uninstantiated open drawer - #43326
Open
ShakilUrRehman21 wants to merge 2 commits into
Open
ShakilUrRehman21 wants to merge 2 commits into
ShakilUrRehman21 wants to merge 2 commits into
Conversation
✅ Deploy Preview for twbs-bootstrap ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When a user clicks a drawer toggle button, the click handler closes any currently open drawer.
However, it previously called
Drawer.getInstance(alreadyOpen)!.hide().If the open drawer was not instantiated yet,
getInstance()returnednull.The forced non-null assertion caused an unhandled
TypeError: Cannot read properties of null (reading 'hide').This issue occurred with server-rendered dialogs, native
.showModal()calls, or drawer switches.Additionally:
dialog.drawer[open], ignoring responsive drawers like.md:drawer.targetwas null.Solution
Drawer.getOrCreateInstance(alreadyOpen).hide()instead ofDrawer.getInstance(alreadyOpen)!.hide().SELECTOR_OPENso responsive open drawers are also matched.if (!target || isDisabled(this)) returnto handle missing targets safely.Motivation and Context
Fixes an unhandled JavaScript crash during drawer toggle interactions. Matches the safe instance resolution pattern used in
js/src/dialog.ts.How Has This Been Tested?
js/tests/unit/drawer.spec.js:should not throw if another open drawer does not have a Drawer instance yetshould call hide first if another responsive drawer is openshould not throw if target element does not existnpm run js-lint: 0 errors.npm run js-typecheck: 0 errors.