Repository navigation
fix(js): recognize modern DOM events in EventHandler nativeEvents set - #43293
Open
ShakilUrRehman21 wants to merge 1 commit into
Open
ShakilUrRehman21 wants to merge 1 commit into
ShakilUrRehman21 wants to merge 1 commit into
Conversation
✅ Deploy Preview for twbs-bootstrap ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
ShakilUrRehman21
force-pushed
the
fix/event-handler-native-events-list
branch
from
November 13, 2026 13:20
9506305 to
15aaacb
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In
js/src/dom/event-handler.ts,normalizeParameters()checksnativeEvents.has(typeEvent)to distinguish native DOM events from custom events. If an event is not innativeEvents, it retains the dot namespace in the event type:Because browsers do not recognize namespaced event names, registering namespaced listeners for valid modern DOM events (such as
cancel.bs.dialog,beforeinput.bs.otp, ortoggle.bs.popover) causes the listener to fail silently and never execute.This PR adds standard modern DOM events to
nativeEvents:beforeinput(used by OTP input and rich text controls)cancelandclose(HTML5<dialog>and<form method="dialog">)toggle(HTML5<details>and Popover API)copyandcut(Clipboard API)drag,dragstart,dragend,dragenter,dragleave,dragover,drop(Drag and Drop API)selectionchange(Selection API)Motivation and context
Ensures standard modern native DOM events can be namespaced and managed through Bootstrap's
EventHandlerutility.Type of changes
Checklist
npm run bundlewatch