Repository navigation
Fix Combobox search input cursor hijacking on Home and End keys - #43289
Closed
ShakilUrRehman21 wants to merge 2 commits into
Closed
ShakilUrRehman21 wants to merge 2 commits into
ShakilUrRehman21 wants to merge 2 commits into
Conversation
julien-deramond
added
v6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In
Combobox, pressingHomeorEndinside.combobox-search-inputunexpectedly moved focus to the first or last dropdown item instead of letting the user navigate their search query cursor.This change adds an
!isInputcheck in_handleMenuKeydown()forKEY_HOMEandKEY_END, matching the behavior of standard search inputs.Motivation and context
Fixes keyboard text navigation in the Combobox search input.
Type of changes
Checklist