Repository navigation
Conversation
When a link inside a menu becomes active, ScrollSpy also adds `.active` to the menu toggle. It only removed `.active` from `[href]` elements on the next activation, so a `<button data-bs-toggle="menu">` toggle, as in the navbar docs, stayed active after a link outside the menu took over. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
.menubecomes active,_activateParents()also adds.activeto the menu toggle._clearActiveClass()only removed.activefrom[href]elements. The navbar docs use<button class="nav-link" data-bs-toggle="menu">toggles, so the toggle kept.activeafter a link outside the menu became active. Two nav items then looked active._clearActiveClass()now also clears[data-bs-toggle="menu"].active.js/tests/unit/scrollspy.spec.jsscrolls to a section linked from the menu, then back to a section linked from the nav. It fails before the change (expected BUTTON not to have class "active") and passes after it. The full unit suite passes (1374 tests).Motivation & Context
Type of changes
Checklist
npm run lint)Live previews
Related issues
I used Claude Code to write this change.