Repository navigation
Conversation
With a Chinese, Japanese or Korean input method, the Enter that commits the composed text also created a chip from the uncommitted text, and the Escape that cancels the composition cleared the whole input. The input keydown handler now returns early when the keydown belongs to a composition: `isComposing` is true, or keyCode is 229 (Safari sends the committing keydown after `compositionend`). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
_handleInputKeydown()now returns early when the keydown belongs to an IME composition:event.isComposingis true, orkeyCodeis 229.compositionend, withkeyCode229. The second check covers it.js/tests/unit/chips.spec.jsdispatch these keydowns. Before the fix they fail withexpected [ 'とうきょう' ] to deeply equal []andexpected '' to deeply equal 'とうきょう'. After the fix the chips spec passes.Motivation & Context
とうきょうbefore conversion to東京. Escape clears the whole input.Type of changes
Checklist
npm run lint)Live previews
Related issues
I used Claude Code to write this change.