Repository navigation
Combobox: fire native input and change events from the hidden input - #43261
samyferhat wants to merge 2 commits into
Conversation
A native select fires input and change when its value changes. The combobox only fired change.bs.combobox on the toggle, so form listeners never saw the new value. The hidden input now fires both events when its value changes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Looks good to me. Two things:
|
Without a hidden input, the combobox fired no native event, so a form listener never saw the change. The toggle now fires input and change in that case, like twbs#43300 does. Add a test for a selection made with Enter. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
✅ Deploy Preview for twbs-bootstrap ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Thanks for the heads-up on #43300!
|
Description
inputthenchangeevents. Both bubble, like on a<select>.name, the toggle fires the same events. This matches Unify chip input and editable Combobox #43300.name, an unchanged value, and the init sync.Motivation & Context
change.bs.comboboxon the toggle. A form listener never saw the new value.event.target.nameandevent.target.valuework as with a native field.Type of changes
Checklist
npm run lint)Live previews
Related issues
Fixes #43001
🤖 Generated with Claude Code