Repository navigation
Add ADMIRE beamformer - #650
Draft
tristan-deep wants to merge 3 commits into
Draft
tristan-deep wants to merge 3 commits into
tristan-deep wants to merge 3 commits into
Conversation
ADMIRE suppresses off-axis and multipath clutter by fitting a model of point-scatterer wavefronts to the aperture-domain signal of short axial windows, frequency by frequency, and keeping only the scatterers near each image line. - zea.beamform.admire: model generation (NumPy, cached, optionally parallel over windows) and the elastic-net fit (Keras ops, all backends), ported from the VU-BEAM-Lab reference code (Apache-2.0) - ops.ADMIRE, also available as Beamform(beamformer="admire") - The ICA eigenvector phases are fixed so the models are reproducible across platforms; the calibration table is matched to the nearest center frequency - Tests, including checks against ports of the reference solver and ICA - Citations requested by the reference authors
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
…ted grids Beamform(beamformer="admire") now defaults to num_patches=1, and asking for patching raises an error that says to use num_patches=1. The ADMIRE operation warns, before generating models, when the grid is not cartesian (such as a polar sector grid) or when most columns have their sub-aperture beyond the array.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds ADMIRE (Aperture Domain Model Image REconstruction), a model-based beamformer that suppresses off-axis and multipath clutter. For each short depth window and frequency, it fits the aperture-domain signal with modeled point-scatterer wavefronts (elastic net, coordinate descent) and keeps only the part explained by scatterers near the image line.
What's in here
zea.beamform.admire: model generation (NumPy, cached on disk, optionally parallel withn_workers) and the fit (Keras ops, runs on every backend). Ported from the VU-BEAM-Lab reference.ops.ADMIRE, also usable asBeamform(beamformer="admire").Carotid example
zea-carotid-2023, 21 compounded plane waves, 65-element sub-apertures. DAS left, ADMIRE right:Things to know
ica.m) depends on the arbitrary phase of the eigenvectors the linear algebra library returns for complex data, so its models differ per platform. Those phases are fixed here so models are reproducible. The calibration table is matched to the nearest listed frequency, and IQ data plus compounded plane and diverging waves are supported. The reference targets focused, walked-aperture RF data.