Fix browser auth fallback - #41
Draft
gardinermichael wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-keep-opendurations and skip the fallback for remote CDP and pre-launch profile errorsRoot cause
Chrome can load a copied signed-in profile differently in headless mode and redirect NotebookLM to Google's account chooser. The existing auth flow treated that redirect as expired authentication and exited, even though the same profile could authenticate in a visible browser.
User impact
nlm auth loginremains headless-first. When Google rejects or cannot restore that headless session, nlm now opens a visible browser once and gives the user time to complete account selection before harvesting credentials.Validation
go test ./...~/.nlm/envnlm notebook list --limit 1succeeds with the refreshed credentials