Repository navigation
Conversation
Signed-off-by: Yusuf Efe <120668197+yuefdev@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
atan2so points at the same latitude and longitude can have vertical elevation angles. Ascents currently return 0° instead of 90°, and descents return 0° instead of -90°.The regression covers ascent, descent and identical points through both APIs, in degrees and radians. The ascent and descent cases fail against the old function. All 153 tests previously passed on this commit; the focused regression passes again.
Strict mypy still reports the 19 errors also present on the base branch.