Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Appending extension schemas to a new GPX object before its first
to_xml()call suppresses the default GPX schema pair. Ensure the current GPX namespace has a schema pair before serialization, while retaining extension pairs and any explicitly supplied schema URL for that namespace. Repeated serialization does not add duplicates.Fixes #210.
Validation: the new regression fails on the original implementation for GPX 1.0 and 1.1 and passes after the fix. All 154 unittest tests pass;
make run-gpxinfopasses. Verified the issue reproduction survives an XML parse/serialize round trip, and a custom GPX schema URL stays unchanged. Strict mypy reports the same 19 errors as the unchanged baseline, with no new diagnostics (mypy 2.4.0).AI assistance: prepared and verified with OpenAI Codex.