Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplifying a closed track whose points share a longitude can currently delete the entire excursion. With identical endpoints, the approximate baseline has no direction and selects the first interior point rather than the farthest point; a nearby first point then makes a 200 km loop collapse to two identical endpoints.
For coincident endpoints, select the farthest interior point by its 2D distance from the endpoint. Ordinary open-polyline simplification keeps its existing path.
Validation: a public track-segment regression fails on the original code, and a small-loop control still collapses within tolerance. All 154 unit tests pass. Strict mypy reports the same 19 existing errors on the unchanged base and this branch; repository CI runs the unit suite.