Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GPXTrack.join(1, 0)treats the explicitly supplied segment index0as if the argument had been omitted. With three one-point segments at latitudes 0, 1, and 2, it produces[[0], [1, 2]]instead of[[1, 0], [2]].Check for
Nonewhen choosing the default second segment. This preserves the existing default behavior while allowing joins into segment zero. Add regression coverage for joining segments 1 and 2 with zero, an explicit nonzero target, and the default target; also verify destination segment identity.Validation on macOS / Python 3.13.14:
python -m unittest test: 153 tests passed, using both the standard-library XML backend and lxml.python gpxinfo test_files/*.gpx: passed.git diff --check: passed.mypy --strict . gpxinfowith mypy 2.4.0 reports 19 existing diagnostics. The same diagnostics reproduce in an unchanged archive of the upstream commit; this change adds none.The two explicit-zero regression cases fail before the fix and pass afterward. This contribution was prepared with assistance from OpenAI Codex.