Repository navigation
Empty track segment flips GPX.has_times() to True, blocking fill_time_data_with_regular_intervals - #299
Open
Str0k wants to merge 1 commit into
Open
Empty track segment flips GPX.has_times() to True, blocking fill_time_data_with_regular_intervals#299Str0k wants to merge 1 commit into
Str0k wants to merge 1 commit into
Conversation
…_data_with_regular_intervals
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An empty track segment makes
GPXTrack.has_times()returnTrueeven when every point in the track lacks a timestamp. Consequently,fill_time_data_with_regular_intervals(force=False)rejects a file that has no time data.Restore AND aggregation across segments. An empty segment then remains neutral, as documented by
GPXTrackSegment.has_times(). The change also restores the behavior before commit81cb1eb. Three new unittest cases cover time availability, filling missing times, and a valid timed track; they are included in the repository'spython -m unittest testentry point.Validation against base
df845044cc87ba6401e494a3a177ed007ff0f6eb:python -m unittest testgpxinfoon repository fixturesThe regression and complete suites were reproduced in independent clean checkouts. The separate pytest adapter also passed after the patch; the native unittest counts above avoid its duplicate collection of imported tests.
AI assistance: implementation and independent code review used Hermes with self-hosted GLM 5.3. Automated validation was reproduced separately. This does not represent a human review.