Fix incremental caller loss after re-exported symbol rename - #1062
Open
vincedk-alt wants to merge 1 commit into
Open
vincedk-alt wants to merge 1 commit into
vincedk-alt wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An incremental update after renaming an exported TypeScript function can lose callers in unchanged files that import through a re-export. The dependency walk finds those files, but the content-hash shortcut skips reparsing them, leaving edges pointed at the old symbol identity. A full rebuild finds all three callers; the incremental update finds only one.
Invalidate the discovered dependents when the seed file actually changed, while retaining the no-op shortcut for duplicate notifications. Reuse the hash read so parse-stage snapshot coherence is preserved.
Validation: the new synthetic rename/re-export regression fails on v2.3.9 and passes with this patch; all 140 incremental tests pass, including snapshot-race coverage. No application source is included.