Skip to content

Fix composer routing for selected and persisted models #6978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
senamakel merged 19 commits into from
Oct 7, 2026
Merged

Fix composer routing for selected and persisted models #6978

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
ddaaf20
fix(chat): honor selected and persisted provider routes
SayrWolfridge Oct 3, 2026
e4b823d
test: preserve persisted routing in default composer sends
SayrWolfridge Oct 3, 2026
964e79a
test: preserve blank picker defaults and turn-local temperature
SayrWolfridge Oct 4, 2026
74c0ba6
test: type composer send mocks for payload assertions
SayrWolfridge Oct 5, 2026
aed298d
Merge current main and preserve explicit composer routing
SayrWolfridge Oct 5, 2026
6ed45f8
Fix picker persistence races, managed cache identity and LocalOnly ro…
SayrWolfridge Oct 5, 2026
89ed4c9
Retry failed composer clears and normalize configured cloud provider …
SayrWolfridge Oct 6, 2026
660cbaf
Use const for the composer clear barrier binding
SayrWolfridge Oct 6, 2026
5f50ced
Merge remote-tracking branch 'refs/remotes/upstream/main' into pr/6978
senamakel Oct 6, 2026
d00380d
fix: harden composer model routing
senamakel Oct 6, 2026
4564cdc
test: isolate composer thread API mocks
senamakel Oct 6, 2026
c2186de
test: cover composer picker routes
senamakel Oct 6, 2026
1797839
test: cover composer routing at core boundary
senamakel Oct 6, 2026
1dfad86
fix: clear composer CI gates
senamakel Oct 6, 2026
74ab8a5
test: cover unknown composer provider route
senamakel Oct 6, 2026
4ac90a7
test: tighten composer route coverage
senamakel Oct 6, 2026
fb7b4dc
test: cover unknown provider at rpc boundary
senamakel Oct 6, 2026
98a859c
Merge commit '7578346c85973c61afbfe6e24d88eb0a174ba014' into codex/fi…
SayrWolfridge Oct 7, 2026
893f6db
fix(chat): retain rejected drafts and scope routing RPC assertions
SayrWolfridge Oct 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions app/scripts/e2e-run-all-flows.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -408,6 +408,7 @@ if should_run_suite "settings"; then
run "test/e2e/specs/settings-advanced-config.spec.ts" "settings-advanced" "settings"
run "test/e2e/specs/settings-feature-preferences.spec.ts" "settings-features" "settings"
run "test/e2e/specs/settings-search.spec.ts" "settings-search" "settings"
run "test/e2e/specs/chip-tabs-keyboard.spec.ts" "chip-tabs-keyboard" "settings"
Comment thread
senamakel marked this conversation as resolved.

@tinysweeper tinysweeper Bot Oct 6, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

priority medium tests likely

Add the registered chip-tabs spec before running it

The settings suite invokes a chip-tabs keyboard spec that has not been added in this pull request. I could not find test/e2e/specs/chip-tabs-keyboard.spec.ts anywhere in the diff, and a runner entry pointing at a nonexistent file fails the settings flow (or is silently skipped, depending on the runner's error policy) — the behaviour this entry claims to cover is asserted nowhere. The earlier finding stands unchanged; either commit the spec alongside this registration or drop the line until it exists.

Additional e2e observation

priority medium likely

Register the chip-tabs spec only if it exists

[RULE] e2e-uncovered

The settings suite invokes a chip-tabs keyboard spec that I could not find in the repository tree; until that spec file exists, this run line either fails or silently registers a flow for nothing. Either commit the spec or drop this registration until it is written. Not fixed by this commit; kept from earlier revisions.

[RULE] missing-registered-e2e-spec ·

_mini_summary "settings"
fi

Expand Down
Loading
Loading