📝 docs(vm): correct the element types Object::static_type reports - #216
Merged
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b547ee32cf
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
The comment said container element types are reported as `Any` with `Tuple` as the sole exception. Lists, deques, maps, and `Some` read their element types from their contents too — as the `Performance` note on `Value::static_type` directly above already says. Iterators and heaps are the ones that report `Any`. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
timfennis
force-pushed
the
housekeeping/static-type-doc-comment
branch
from
September 2, 2026 18:43
b547ee3 to
a4b48ce
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Noticed while rebasing
feat/explicit-numeric-modes(#210) onto the as-cast work. That branch dropped a commit which, among other things, had fixed this comment — so the inaccuracy stays on master until someone corrects it on its own.Change
Object::static_type's doc comment claimed container element types are reported asAny, withTupleas the sole exception. The body says otherwise: lists, deques, maps, andSomeall derive element types from their contents vialub. Iterators and heaps are the variants that reportAny.The
# Performancenote onValue::static_type, immediately above, already documents the O(n) element scan forList,Map, andDeque— so the two comments contradicted each other. Comment only, no behaviour change.🤖