Skip to content
This repository was archived by the owner on Nov 17, 2022. It is now read-only.
This repository was archived by the owner on Nov 17, 2022. It is now read-only.

Tests call await client.destroy(), but destroy() doesn't return a promise  #32

Description

@lewisdaly

This is a minor nitpick, but I noticed it and was confused, so I figured I'd open an issue for it.

According to the Client interface, destroy returns void:
https://github.com/tigerbeetledb/tigerbeetle-node/blob/de2272194719a33a013ab5f0a09ce4bead91283c/src/index.ts#L200

But in the tests we have: https://github.com/tigerbeetledb/tigerbeetle-node/blob/de2272194719a33a013ab5f0a09ce4bead91283c/src/test.ts#L343

I'm guessing that the line in the tests are a simple typo.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions