Repository navigation
Conversation
The reader no longer pre-allocates more rows than readstat can deliver: the initial allocation is capped at `n_max`, and when `n_max = 0` the value handler is not registered so readstat skips parsing values entirely. This reduces a header-only parse of an 80 MB XPT file from ~39 MB to ~5 KB allocated. Fixes #845.
- Count rows only as they are seen, so `nrows_` is no longer seeded from the (potentially inaccurate) header row count - Remove now-redundant `limitRows()`; readstat enforces `n_max` itself - Guarantee growth progress when reallocating, fixing a potential out-of-bounds write when a header declares 0 rows - Document `nrows_`/`nrowsAlloc_` fields
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Written by AI 🤖
Fixes #845.
Header-only parse of an 80 MB XPT file drops from ~39 MB to ~5 KB allocated.