SCAL-337597 Add filter host event example in Liveboard embed - #68
Open
ts-nk-github-cplot wants to merge 2 commits into
Open
SCAL-337597 Add filter host event example in Liveboard embed#68ts-nk-github-cplot wants to merge 2 commits into
ts-nk-github-cplot wants to merge 2 commits into
Conversation
ts-nk-github-cplot
force-pushed
the
SCAL-337597
branch
from
September 10, 2026 11:33
6d25951 to
ec1d5ba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a new demo: Add Filter (Edit Mode) — embeds a ThoughtSpot Liveboard and adds an "Add Filter" button outside the embedded UI. Clicking it triggers
HostEvent.Editto enter edit mode, thenHostEvent.OpenAddFilterModalto open the Add Filter modal, sequenced off the SDK's own readiness signals rather thantrigger()'s unreliable promise.Ships as two equivalent, independently runnable implementations:
vanilla/— plain JS + Vitereact/— same logic ported to React, using the official@thoughtspot/visual-embed-sdk/reactLiveboardEmbedcomponent and hooksTest plan
cd vanilla && npm install && npm run dev(port 8642) — click Add Filter, confirm edit mode + modal open on first clickcd react && npm install && npm run dev(port 8643) — same checkisTransitioningguard); button re-enables once the first sequence finishes.