fix(react-ui): step curve, scrolling x-axis labels, donut and radar hover in the D3 charts - #1271
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
i-subham23
added this pull request to stack #1272
September 30, 2026 08:57
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1248 and #1263. Fixes TH-2661, TH-2662, TH-2663 and TH-2664: the chart issues QA raised in #qa after comparing the D3 charts with the Recharts ones.
Changes
Step curve
variant→ curve mapping,seriesCurveinshared/cartesian/seriesGeometry.ts."step"is now d3curveStep(it wascurveStepAfter), which the D3 mini charts already use."natural".Scrolling labels (
utils/xAxisLabelLayout.ts,hooks/cartesian/useChartDimensions.ts)tickVariant="singleLine").BarChartpasseslabelShareand categories are sized for that.tickVariantJSDoc now says how scrolling and condensed charts differ.Donut (
PieChart,PieSlices)sunktrack wedges run from the hole (28% of the band's inner radius) to the band. Both take the slice's corner radius.paddingAngle.paddingAnglestill sets the pie's gaps, and its JSDoc now says so.Radar hover
FadeFollowers. They glide from axis to axis on thecrosshairspring and fade over 120ms.showDotson, the vertex dots still show the hover as before.active-dot-stylesmixin shared with the line and area crosshair, so the line and area CSS is unchanged.