Conversation
|
@shogun444 is attempting to deploy a commit to the thesys-devs Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes an issue where using Windows Voice Typing (
Win+H) and pressing Enter or Send mid-dictation causes text to duplicate in the draft (e.g.,"welcome to Welcome to my house"), reappear after submission, or swallow subsequent speech.This change introduces a shared composition hook that cleanly commits a single copy on the first Enter, drops trailing microphone noise, allows clean subsequent dictation to append without duplication, and ensures the draft remains cleared after sending.
Closes #1227
Refs #1045, #1068, #1228
Changes
ComposerandDesktopWelcomeComposerintouseComposerComposition.Win+Hsession cleanly appends new text after the committed draft without repeating previous words.compositionend/onChangeechoes, keeping the draft clean across rounds.compositionendfallback: Automatically flushes pending commits if the OS fails to emit a terminal composition event.keyCode === 229/isComposing),Shift+Enternewlines, normal Send button click flow, and streaming cancellation.Test Plan
Environment
Validation Steps
Win+Hand pressed Enter mid-speechWin+Hand dictated againComposer(thread view) andDesktopWelcomeComposer.Shift+Enternewlines, and CJK IME conversions remain unaffected.Automated Tests
pnpm vitest run src/components/AgentInterface/__tests__/composerKeyboard.test.ts(all 26 tests passed).pnpm run typecheck(no new errors introduced).Demo
[
Video.Project.56.1.mp4
](url)
Checklist