Skip to content

fix(navigation): fix client-side navigation with reactive useAsyncData keys #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wazolab merged 3 commits into from
Aug 2, 2026
Merged

fix(navigation): fix client-side navigation with reactive useAsyncData keys #214

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e17cb0c
Merge pull request #212 from teritorio/develop
wazolab Jul 28, 2026
2c64e7b
fix(navigation): use reactive useAsyncData keys to fix client-side na…
wazolab Jul 31, 2026
e65f55e
fix(navigation): handle 404 reactively for client-side navigation
wazolab Aug 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions app.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ import { en, es, fr } from '@nuxt/ui/locale'
const uiLocales: Record<string, typeof en> = { en, fr, es }

const { t, locale } = useI18n()
const route = useRoute()
const uiLocale = computed(() => uiLocales[locale.value] || en)

useSeoMeta({
Expand Down Expand Up @@ -34,7 +33,7 @@ useSchemaOrg([
<template>
<UApp :locale="uiLocale">
<NuxtLayout>
<NuxtPage :page-key="route.path" />
<NuxtPage :page-key="locale" />
</NuxtLayout>
</UApp>
</template>
17 changes: 11 additions & 6 deletions pages/[...slug].vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,19 +10,24 @@ const path = computed(() => {
return `/${locale.value}/${slug.value.join('/')}`
})

const { data: page } = await useAsyncData(
`slug-${locale.value}-${slug.value.join('/')}`,
const { data: page, status: pageStatus } = await useAsyncData(
() => `slug-${locale.value}-${slug.value.join('/')}`,
() => queryCollection(collectionName.value).path(path.value).first(),
)

if (!page.value) {
throw createError({ statusCode: 404, statusMessage: 'Page not found' })
}

watch(pageStatus, (status) => {
if (status === 'success' && !page.value) {
showError({ statusCode: 404, statusMessage: 'Page not found' })
}
})

const { data: navigation } = await useAsyncData(
`navigation-${locale.value}`,
() => `navigation-${locale.value}`,
() => queryCollectionNavigation(collectionName.value),
{ watch: [locale] },
)

const docsSections = computed(() => extractDocsSections(navigation.value ?? []))
Expand All @@ -34,7 +39,7 @@ const sectionSlug = computed<string | undefined>(() => {
})

const { data: sectionIndex } = await useAsyncData(
`breadcrumb-section-${locale.value}-${sectionSlug.value ?? ''}`,
() => `breadcrumb-section-${locale.value}-${sectionSlug.value ?? ''}`,
() => {
const section = sectionSlug.value
return section
Expand All @@ -44,7 +49,7 @@ const { data: sectionIndex } = await useAsyncData(
)

const { data: rawSurround } = await useAsyncData(
`surround-${locale.value}-${slug.value.join('/')}`,
() => `surround-${locale.value}-${slug.value.join('/')}`,
() => isDocsPage.value
? queryCollectionItemSurroundings(collectionName.value, path.value, { before: 2, after: 2 })
: Promise.resolve(null),
Expand Down
Loading