[a11y] Fix nested interactive elements in Copyable component (WCAG 4.1.2)#3558
Open
rosanusi wants to merge 1 commit into
Open
[a11y] Fix nested interactive elements in Copyable component (WCAG 4.1.2)#3558rosanusi wants to merge 1 commit into
rosanusi wants to merge 1 commit into
Conversation
Replaces outer <button> wrapper in clickAllToCopy mode with a <div>, moving click-to-copy into an inner <button> sibling of CopyButton. Eliminates WCAG 2.2 SC 4.1.2 violation (button inside button). A11y-Audit-Ref: 4.1.2-copyable-nested-interactive Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<button>wrapper inclickAllToCopymode with a<div class="group">, moving the click-to-copy action into an inner<button>sibling ofCopyButtonaria-label={\Copy ${content}`}` so screen readers announce it meaningfullygroupclass stays on the<div>, sogroup-hover:visible/group-focus-within:visibleTailwind utilities continue to work for theCopyButtonrevealTest plan
clickAllToCopymode renders<div>wrapping two sibling buttons (no button-in-button)CopyButtonbecomes visible viagroup-hover:visibleCopyButtonstays visible viagroup-focus-within:visibleA11y-Audit-Ref: 4.1.2-copyable-nested-interactive
🤖 Generated with Claude Code