Fix rpmlint failures in RPM packaging - #5163
Open
tcornell-bus wants to merge 3 commits into
Open
tcornell-bus wants to merge 3 commits into
tcornell-bus wants to merge 3 commits into
Conversation
Update rpmlintrc filters for the tmt package rename and provisioner spelling. Drop the redundant libvirt-daemon-config-network Requires already pulled in by python3-testcloud. Assisted-by: Cursor AI
tcornell-bus
force-pushed
the
tcornell-fix-rpmlint
branch
from
September 15, 2026 17:23
a4d1941 to
2dc4343
Compare
tcornell-bus
added
the
ci | full test
happz
reviewed
Sep 15, 2026
| @@ -1,5 +1,9 @@ | |||
| # The detach runner is intentionally not executable | |||
Contributor
There was a problem hiding this comment.
Is this line stil valid when the rule gets removed?
Member
There was a problem hiding this comment.
It is not removed, we just changed the package name and forgot to alter the rule also.
Although... why do we not make it executable?
Contributor
Author
Member
There was a problem hiding this comment.
The support for the ancient detach execute method was dropped in:
Just forgotten line, can be safely removed.
LecrisUT
reviewed
Sep 16, 2026
LecrisUT
left a comment
LecrisUT
left a comment
Member
There was a problem hiding this comment.
Can also skip the no-documentation issues?
Catch warnings and errors for provisioner spelling
LecrisUT
approved these changes
Sep 16, 2026
therazix
approved these changes
Sep 16, 2026
psss
approved these changes
Sep 21, 2026
| @@ -1,5 +1,12 @@ | |||
| # The detach runner is intentionally not executable | |||
| addFilter("python3-tmt.noarch: E: non-executable-script") | |||
| # same with Jinja2 template scripts | |||
Member
There was a problem hiding this comment.
So we just need to reword this one.
psss
changed the title
rpmlint failures in RPM packaging
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update
rpmlintrcfilter for:libvirt-daemon-config-networkRequiresalready pulled in bypython3-testcloud.python3-testcloud(required since Fedora 43 through current Rawhide) listslibvirt-daemon-config-networkas one of its ownRequires. Sincetmt+provision-virtualalready requirespython3-testcloud >= 0.11.7, thelibvirt-daemon-config-networkdependency was being pulled in twice — once explicitly by tmt and once transitively through testcloud.Assisted-by: Cursor AI
Fixes: #3323
Pull Request Checklist