Repository navigation
feat(grid): support highlighting duplicate and null values in column context menu - #11153
Merged
Merged
Conversation
lxk955
force-pushed
the
feat/8794-highlight-duplicates-nulls
branch
from
October 7, 2026 03:50
ed987c0 to
cdd2015
Compare
lxk955
force-pushed
the
feat/8794-highlight-duplicates-nulls
branch
from
October 7, 2026 03:52
cdd2015 to
e3c1057
Compare
t8y2
reviewed
Oct 7, 2026
t8y2
left a comment
Owner
There was a problem hiding this comment.
Maintainer patch in 82c275c (on top of e3c1057) — the feature structure is solid (pure lib extraction, canvas/DOM/transpose parity, 12-locale i18n); this closes the two blocking review notes:
- Perf:
columnHighlightMatchesnow short-circuits to empty key sets when no highlight rules are active, before touchingdisplayItems. Previously the computed eagerly materialized everyRowItem(displayRowRefs.map(...)) on each edit/filter/load-more invalidation even with the feature unused — the canvas draw reads the key sets every frame. This follows theuseDataGridSearchempty-query early-return precedent (#8524). TheisNullValuewiring is factored into a sharedcolumnHighlightMatchesForhelper. - Toast accuracy: the duplicate/NULL toast counts are now computed from the toggled columns' rules only. Previously the count spanned every active highlight column, so enabling duplicates on an all-unique column could toast another column's match count.
Deferred as a follow-up (wording choice, not patched): detection covers loaded rows only, so "No duplicate values found" can be premature on streamed results — consider "in loaded rows" phrasing later.
Checks run locally: vitest run dataGridColumnHighlight.spec.ts dataGridContextMenu.spec.ts — 21/21 passed; git diff --check clean.
Owner
|
Thanks for the contribution! Merged in 79dca4b, will be released in the next version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8794
Summary