Repository navigation
feat(structure): remove dynamic toggle labels from table editor checkboxes (#8148) - #11150
Merged
t8y2 merged 2 commits intoOct 7, 2026
Merged
Conversation
t8y2
reviewed
Oct 7, 2026
t8y2
left a comment
Owner
There was a problem hiding this comment.
维护者补丁(bce848256,基于 c23d5f4):为列表格的 primaryKey 复选框补上 :aria-label="t('structureEditor.primaryKey')",与本 PR 为 nullable 复选框建立的「裸复选框 + aria-label」模式保持一致(该 key 全部 12 个语言文件均已存在)。
核验:TableStructureEditor.metadataRevalidation.spec.ts(42 用例)、columnSelectionCopy / concurrentTransition spec(9 用例)全部通过,oxfmt 格式检查通过。其余审阅结论不变,CI 跑完后即可合并。
Owner
|
Thanks for the contribution! Merged in 7e324bd, will be released in the next version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #8148
When editing table structures and indexes, checkboxes for
nullable(fields tab),unique(indexes tab), andconcurrent(indexes tab) had dynamic text labels (是/否viat("structureEditor.yes") : t("structureEditor.no")) that morphed between "Yes" and "No" upon toggling. In a tabular grid where the column header already specifies the attribute ("Nullable", "Unique", "Concurrent"), flipping text labels beside the checkboxes is counterintuitive and visually inconsistent with other columns such as Primary Key.Changes
TableStructureEditor.vue:<span>{{ ... ? yes : no }}</span>labels from thenullablecolumn in the columns table, centering its cell and header to match the Primary Key column.<span>{{ ... ? yes : no }}</span>labels from theuniqueandconcurrentcolumns in the indexes table, centering their cells and headers.aria-labels to the checkbox inputs for accessibility.TableStructureEditor.metadataRevalidation.spec.ts:Verification
pnpm test apps/desktop/src/components/structure/__tests__/TableStructureEditor.metadataRevalidation.spec.ts(all 42 tests passed).