feat: make foreground service opt-in

[jvsena42]

Fixes #1007

This PR:

1. Adds a "Keep Bitkit active in background" toggle to the Background Payments screen that makes the persistent foreground service opt-in and disabled by default. The Lightning node still runs while the app is open, and background payments still arrive via push notifications; enabling the toggle keeps Bitkit active in the background for more reliable payments, at the cost of a persistent notification.
2. Updates the Background Payments screen and the notification preview to match the latest design.
3. Always shows the amount in payment notifications and removes the "Include amount in notifications" option.
4. Fixes a Lightning event-handler leak so toggling the service on and off no longer accumulates stale handlers.

Description

• New persisted setting, off by default. The foreground service start gate now also requires it, and turning it off stops a running service immediately so the persistent notification disappears at once.
• Stopping the foreground service no longer stops the in-app node when an activity is active; in the foreground the node lifecycle is owned by the wallet view model, so toggling the service off leaves the node running. When the app is backgrounded, the node still stops as before.
• The Background Payments screen is reordered to match the design: "Get paid when Bitkit is closed", "Keep Bitkit active in background", a Notifications section with the Customize button, and a Preview of the payment notification. The "Keep Bitkit active in background" switch is disabled while notifications are denied.
• The notification preview is redesigned to the Android notification card style, with the app icon, title, time, amount, and an expand chevron.
• Removed the show-notification-details setting and its privacy toggle. Payment notifications now always include the amount across the foreground service, in-app handler, and the background push path.
• Added a remove-event-handler API and de-register the foreground service handler when the service is destroyed, preventing stale handlers from accumulating across service restarts.

Preview

disable-fg-switch.webm

disable-notifications.webm

running-from-master.webm

wake-to-pay.webm

enable-fg-service.webm

QA Notes

FIGMA

Manual Tests

• 1. Settings → Background Payments: "Keep Bitkit active in background" is off by default and no persistent Bitkit notification is shown in the status bar.
• 2. Background Payments → toggle Keep active on: persistent Bitkit notification appears → background the app: node stays alive.
• 3. Background Payments → toggle Keep active off: persistent notification disappears immediately → with the app still open, receive a payment: still works (node keeps running).
• 4. Revoke notification permission in Android settings → Background Payments: "Get paid when Bitkit is closed" reads off and "Keep Bitkit active in background" is disabled.
• 5. regression: Keep active off, app closed → receive a payment: push notification arrives and shows the amount.
• 6. Background Payments: layout matches the design (two switches with explanations, Notifications/Customize, Preview card).

Automated Checks

• Unit tests added: default value and setter for the new toggle in SettingsViewModelTest.kt.
• Test coverage removed: hidden-amount assertions deleted from ReceivedNotificationContentTest.kt and NotifyChannelReadyHandlerTest.kt because the show-notification-details option no longer exists; SettingsData stubs updated in NotifyPaymentReceivedHandlerTest.kt.
• Ran locally: just compile, the affected unit tests, and just lint.
• CI: standard compile, unit test, and detekt checks run by the PR bot.

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b9a98728be

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

[ovitrif]

Reviewed locally. I left two comments: one lifecycle issue around the background transition, and one changelog cleanup. Leaving this as a neutral review.

[ovitrif]

tAck. The two comments from my previous review are more like nits, the first one didn't really repro in my tests.

[piotr-iohk]

tACK

[greptile-apps]

Node leaked after Android 15 foreground-service timeout

When Android 15 fires LightningNodeService.onTimeout() while an activity is active, stopNodeIfBackgrounded() correctly skips stopping the node because the activity is present. The service is then destroyed and nodeServiceFgState.setForegroundServiceRunning(false) is recorded in onDestroy. However, when the user later backgrounds the app, ON_STOP computes keptAliveByService = notificationsGranted && keepActiveInBackground — both of which are still true (they are settings values, not runtime service-alive flags) — so walletViewModel.stop() is never called. The Lightning node then runs indefinitely in the background with no service or activity lifecycle managing it.

The fix is to also require the service to be actually running when deciding whether to skip the node stop. Replacing keepActiveInBackground with a check against NodeServiceFgState.isForegroundServiceRunning (already updated to false in onDestroy) would close this gap — or alternatively setting keepBitkitActiveInBackground = false in onDestroy so that both the settings layer and the service-alive state remain in sync.

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e571137fb2

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".