fix(stripe_fdw): add missing status column to subscriptions table - #623
Merged
burmecia merged 2 commits intoAug 10, 2026
Merged
Conversation
Contributor
Author
|
Hi @burmecia, thanks for merging the PR! Also as I mentioned in the PR description, What do you suggest here?
Let me know your thoughts! |
Contributor
I think option 2 is better as subscription and price is essentially 1:n relationship, the query for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix.
What is the current behavior?
stripe_fdwalready treatsstatusas a pushdown qualifier forstripe.subscriptions, anddocs/catalog/stripe.mdrecommends filtering subscriptions byid, customer, price, status— but thestatuscolumn was never added to the table's column config.As a result,
where status = 'active'fails withERROR: column "status" does not exist, even though both the code and the docs advertise it as filterable.Closes: #317
What is the new behavior?
status textis added to thesubscriptionscolumn config and to the example indocs/catalog/stripe.md, matching the existing pattern already used forrefunds.Also the subscriptions test in
tests.rsis extended to assert the new column.Additional context
pricehas the same missing-column symptom (registered as a pushdown qual atstripe_fdw.rs:336, listed in the same docs note) but isn't fixable the same way —pricelives nested underitems.data[].priceon the Stripe API object, not top-level likestatus, so it needs real flattening logic rather than a column-config addition. Noting it here as a follow-up, not part of this fix.