Repository navigation
ci: check that generated sync code is up to date - #1969
Merged
Merged
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 1 minute. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
spydon
force-pushed
the
lukasklingsbo/sdk-1688-ci-check-generated-sync-code
branch
from
November 4, 2026 14:15
451afa3 to
4d145a1
Compare
spydon
marked this pull request as ready for review
November 4, 2026 14:17
spydon
deleted the
lukasklingsbo/sdk-1688-ci-check-generated-sync-code
branch
November 4, 2026 14:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves SDK-1688.
Adds
.github/workflows/codegen.yml, which runs on pull requests and pushes tomain. It regenerates the sync code withmake auth.build-sync, formats it withmake ruff, and fails with an error naming the command to run ifgit diff --exit-codereports changes.The Linear issue lists
build-syncfor functions, storage, postgrest and supabase, but onlyauthstill has abuild-synctarget (it generatessrc/auth/tests/_sync/), so the check covers exactly that.Notes:
ci.yml.UV_FROZEN=1keeps the Makefile'suv runcalls from rewritinguv.lock, which would otherwise show up as a false diff.The SDK-2795 fix (#1971) is on
main, so the generator now reproduces the committed sync tests and this check passes.