Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/storage/src/storage3/_async/vectors.py
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ async def list(
async def query(
self,
query_vector: VectorData,
topK: int | None = None,
topK: int,
filter: VectorFilter | None = None,
return_distance: bool = True,
return_metadata: bool = True,
Expand Down
2 changes: 1 addition & 1 deletion src/storage/src/storage3/_sync/vectors.py
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ def list(
def query(
self,
query_vector: VectorData,
topK: int | None = None,
topK: int,
filter: VectorFilter | None = None,
return_distance: bool = True,
return_metadata: bool = True,
Expand Down
16 changes: 16 additions & 0 deletions src/storage/tests/test_vectors.py
Original file line number Diff line number Diff line change
Expand Up @@ -326,6 +326,22 @@ async def test_query_vectors_sends_query_and_parses_distance(use_async: bool) ->
assert result.vectors[0].distance == 0.25


@parametrize_clients
async def test_query_vectors_requires_top_k(use_async: bool) -> None:
recorder = Recorder()
with pytest.raises(TypeError, match="topK"):
await run(
use_async,
recorder,
lambda c: c.vectors()
.from_("embeddings")
.index("docs")
.query(VectorData(float32=[0.1, 0.2])),
)

assert recorder.requests == []


@parametrize_clients
async def test_put_vectors_omits_missing_metadata(use_async: bool) -> None:
recorder = Recorder()
Expand Down
Loading