Fix: Allow newlines in SMS OTP templatefix: allow newlines in SMS OTP template#2594
Open
amulya-18 wants to merge 1 commit into
Open
Fix: Allow newlines in SMS OTP templatefix: allow newlines in SMS OTP template#2594amulya-18 wants to merge 1 commit into
amulya-18 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
SMS OTP templates do not correctly render newline characters (
\n).Instead of creating a new line, the literal string
\nappears in the message.What is the new behavior?
Escaped newline characters (
\\n) are converted into actual newline characters (\n) when generating the SMS message.This allows multi-line SMS OTP templates to render correctly.
Additional context
This change is implemented in
generateSMSFromTemplateby replacing escaped newline sequences with actual newline characters before returning the final message.