chore(connect): remove stale typebox test importing deleted src/types/typebox - #510
Merged
jannik-stacks merged 1 commit intoSep 10, 2026
Merged
Conversation
jannik-stacks
enabled auto-merge (squash)
September 10, 2026 10:30
jannik-stacks
self-requested a review
September 10, 2026 10:30
jannik-stacks
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As a contributor to
@stacks/connect, I wantnpx vitest runinpackages/connectto pass on a clean checkout, so that the test suite is usable as a signal.1. Motivation for change
The test suite has been broken on
mainsince the SIP-030 switch. Runningnpx vitest runinpackages/connectfails at collection:tests/typebox.test.tsimports../src/types/typebox, but that module is not in the tree. Tracing the history:feat!: Switch to SIP-030) added bothsrc/types/typebox.tsandtests/typebox.test.ts.ci: update publishing, sub-commitchore: remove unused files) deletedsrc/types/typebox.ts(and the emptysrc/types/zod.ts) but left the test behind.Because no workflow in
.github/workflowsruns the test suite, the orphaned test went unnoticed. The failure takes down the whole run, including the unrelatedrequest.test.ts.2. What was changed
packages/connect/tests/typebox.test.ts.packages/connect/src/index.tsthat referenced the same deleted module:I went with deleting the test rather than restoring the schemas, since 7f3063a removed the source deliberately under "remove unused files", the schemas were never exported, and the TODO comment says they were not final. If reviving TypeBox schemas is still on the roadmap, they are recoverable with
git show 7f3063a^:packages/connect/src/types/typebox.tsand the test can come back alongside them.No
@sinclair/typeboxdevDependency needed removing: it was never declared in anypackage.json, and only appears inpackage-lock.jsontransitively via@jest/schemas.3. How does this impact application developers
No impact. Both changes are test-only or comment-only; nothing in the published bundle or type surface changes. No changeset for that reason.
4. Link to relevant issues and documentation
None; found while running the suite locally.
5. Examples of use cases
N/A - no API surface change.
Type of Change
Does this introduce a breaking change?
No.
Are documentation updates required?
No.
Testing information
mainand runnpx vitest runinpackages/connect.src/index.tschange is comment-only.Before (on
main):After (this branch):
Also verified green:
tsc --project tsconfig.json --noEmit, ESLint, and Prettier on the touched file.Two notes for reviewers, both pre-existing and left alone here:
.github/workflows, which is why this sat broken. Worth adding so it cannot recur.packages/connect/tsconfig.test.jsonis not wired to any npm script, andtsc --project tsconfig.test.json --noEmitcurrently fails on a mixed-arraysignInputsliteral attests/request.test.ts:99(vitest does not type-check, so it does not surface). Out of scope for this PR.Checklist