Update sample project assets - #3360
Conversation
|
I believe this was introduced by #3270 where asset references now include a prefix with the path to the package they originate from. |
Kryptos-FR
left a comment
There was a problem hiding this comment.
A few remarks and questions. Did you make sure to run every single sample?
|
@xen2 this PR made me realize that we don't have CI jobs for the samples. |
…# Beginner tutorial
I just finished testing after my latest set of changes. I ran every single sample (except VR) and verified their functional behavior. |
|
Is there anything else I need to do for this to be merged? I had some follow-up pull requests I wanted to make. |
|
Sorry I'm just AFK for a few more days (end of summer vacations), I'll catch up ASAP! |
Kryptos-FR
left a comment
There was a problem hiding this comment.
While most changes during upgrade should be mechanical, there are a few here that seem suspicious.
Especially the disappearance of the Holes property in the SpaceEscape game, likely breaks the gameplay. Needs additional checks.
| 4d8e2d8be95c637e4735e372c89cd037: tight_r | ||
| 4c0f03f769ed319983f85778cbd9cb5e: leg_r | ||
| e21299c47159fb22aae327f92daaef45: shadow | ||
| 279b921e82c814bccd6dafcae38d3360: root |
There was a problem hiding this comment.
Wondering why all the node ids changed.
There was a problem hiding this comment.
No idea. However, I want to bring something similar to your attention. The reimporter consistently tries to remove MaterialB, and I manually exclude that change from the update every time.
…emo.cs" This reverts commit d8fdda2.
It was never intentional
Many of the samples (15 of them) are compiled and run on Windows (all API) and Linux. I have just added the |
|
I think the test failure was a fluke.
|
PR Details
This pull request updates the sample projects with reimported assets.
Related Issue
I was preparing to do other pull requests related to the sample projects, and the Game Studio prompted me to reimport a bunch of assets. Apparently, their data format has changed a bit since creation.
Types of changes
Checklist