Skip to content

Update sample project assets - #3360

Open
ds5678 wants to merge 9 commits into
stride3d:masterfrom
ds5678:reimport-samples
Open

Update sample project assets#3360
ds5678 wants to merge 9 commits into
stride3d:masterfrom
ds5678:reimport-samples

Conversation

@ds5678

@ds5678 ds5678 commented Aug 16, 2026

Copy link
Copy Markdown
Contributor

PR Details

This pull request updates the sample projects with reimported assets.

Related Issue

I was preparing to do other pull requests related to the sample projects, and the Game Studio prompted me to reimport a bunch of assets. Apparently, their data format has changed a bit since creation.

Types of changes

  • Docs change / refactoring / dependency upgrade

Checklist

  • All new and existing tests passed.
  • I have built and run the editor to try this change out.

@Kryptos-FR

Copy link
Copy Markdown
Member

I believe this was introduced by #3270 where asset references now include a prefix with the path to the package they originate from.

@Kryptos-FR Kryptos-FR left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few remarks and questions. Did you make sure to run every single sample?

Comment thread samples/Physics/BepuSample/Assets/Shared/Models/nav_test.sdm3d
Comment thread samples/StrideSamples.slnx Outdated
@Kryptos-FR

Copy link
Copy Markdown
Member

@xen2 this PR made me realize that we don't have CI jobs for the samples.

@ds5678

ds5678 commented Aug 17, 2026

Copy link
Copy Markdown
Contributor Author

Did you make sure to run every single sample?

I just finished testing after my latest set of changes. I ran every single sample (except VR) and verified their functional behavior.

@ds5678

ds5678 commented Aug 20, 2026

Copy link
Copy Markdown
Contributor Author

Is there anything else I need to do for this to be merged? I had some follow-up pull requests I wanted to make.

@xen2

xen2 commented Aug 20, 2026

Copy link
Copy Markdown
Member

Sorry I'm just AFK for a few more days (end of summer vacations), I'll catch up ASAP!

@Kryptos-FR Kryptos-FR left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While most changes during upgrade should be mechanical, there are a few here that seem suspicious.

Especially the disappearance of the Holes property in the SpaceEscape game, likely breaks the gameplay. Needs additional checks.

Comment thread samples/Games/SpaceEscape/Assets/Shared/LevelBlocks.sdscene
4d8e2d8be95c637e4735e372c89cd037: tight_r
4c0f03f769ed319983f85778cbd9cb5e: leg_r
e21299c47159fb22aae327f92daaef45: shadow
279b921e82c814bccd6dafcae38d3360: root

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering why all the node ids changed.

@ds5678 ds5678 Aug 21, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea. However, I want to bring something similar to your attention. The reimporter consistently tries to remove MaterialB, and I manually exclude that change from the update every time.

https://github.com/ds5678/stride/blob/d8fdda26e5c276ee10f7d7c17d35a1619ea26df5/samples/Templates/Packs/MaterialPackage/Assets/MaterialModel.sdm3d

@ds5678
ds5678 requested a review from Kryptos-FR August 24, 2026 08:27
@xen2

xen2 commented Aug 25, 2026

Copy link
Copy Markdown
Member

@xen2 this PR made me realize that we don't have CI jobs for the samples.

Many of the samples (15 of them) are compiled and run on Windows (all API) and Linux.
It capture screenshot and compare them against gold (with some leeway for gameplay/timing variance)
Here is the job:
https://github.com/stride3d/stride/actions/runs/32810473752
And the source:
https://github.com/stride3d/stride/tree/master/tests/enduser/Stride.Samples.Tests

I have just added the ci-enduser label so that those unit tests run on this PR.

@xen2 xen2 added the ci-enduser Run the end-user sample screenshot + packaging suite on this PR label Aug 25, 2026
@ds5678

ds5678 commented Aug 25, 2026

Copy link
Copy Markdown
Contributor Author

I think the test failure was a fluke.

  • Only one test failed.
  • The same test succeeded on other graphics platforms.
  • I tried to reproduce it locally, but all the tests passed on my machine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-enduser Run the end-user sample screenshot + packaging suite on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants