You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Interesting how well this already works without much new implementation. Since you marked it as a draft, here are some general comments:
UI: In-place resizing of the form to show the feature search results is not an acceptable UI.
The appropriate UI for this case would be a search field that either shows the results in a popup/dropdown, similar to AutoCompleteTextField¹ (which might more fittingly be named TextFieldWithSuggestions) but not accepting free text input or a kind of search field that expands into a (full-screen) search screen/dialog. The latter might be difficult to implement.
Fields: On the one hand, you ask for the doctor specialty, on the other hand, the answers are what the doctors are. I.e. when the question is phrased that way, you'd expect the answer to be "neurology", not "neurologist". So, without adding any functionality, one could just rephrase the question. However, if a doctor's office has multiple specialties, this breaks down somewhat, so actually asking for the specialty would be better. This however would require the osmfeatures library to also add support for fields, including translations.
¹ Don't ask me why I used a Popup rather than a DropdownMenu because I don't remember; if you find out, maybe add a code comment; maybe something to do with that the DropdownMenu robs the text field of its focus?
Don't ask me why I used a Popup rather than a DropdownMenu because I don't remember; if you find out, maybe add a code comment; maybe something to do with that the DropdownMenu robs the text field of its focus?
I don't remember exactly what it was, but I was playing with the AutoCompleteTextField when you had it in a PR (with ExposedDropdownMenuBox) and didn't get it to behave like an acceptable replacement for the Android AutoCompleteTextView.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
new questaccepted new quest proposal (if marked as blocked, it may require upstream work first)
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More of a proof of concept at the moment.
Trying to fix #1020
video_2026-08-27_00-52-03.mp4
Created with some AI help, have not reviewed code yet, but maybe you have opinions on the ui?
Will only display doctors added to https://github.com/openstreetmap/id-tagging-schema/tree/main/data/presets/amenity/doctors. Many of these still miss custom icons