Skip to content

New quest: Doctor speciality - #7044

Draft
paulklie wants to merge 1 commit into
streetcomplete:masterfrom
paulklie:doctor_type
Draft

New quest: Doctor speciality #7044
paulklie wants to merge 1 commit into
streetcomplete:masterfrom
paulklie:doctor_type

Conversation

@paulklie

@paulklie paulklie commented Aug 26, 2026

Copy link
Copy Markdown
Collaborator

More of a proof of concept at the moment.
Trying to fix #1020

video_2026-08-27_00-52-03.mp4

Created with some AI help, have not reviewed code yet, but maybe you have opinions on the ui?

Will only display doctors added to https://github.com/openstreetmap/id-tagging-schema/tree/main/data/presets/amenity/doctors. Many of these still miss custom icons

@paulklie paulklie changed the title tested implementing doctor type quest New quest: Doctor speciality Aug 26, 2026
@paulklie paulklie added the new quest accepted new quest proposal (if marked as blocked, it may require upstream work first) label Aug 26, 2026
@paulklie
paulklie marked this pull request as draft August 27, 2026 23:00
@westnordost

westnordost commented Aug 28, 2026

Copy link
Copy Markdown
Member

Interesting how well this already works without much new implementation. Since you marked it as a draft, here are some general comments:

  1. UI: In-place resizing of the form to show the feature search results is not an acceptable UI.
    The appropriate UI for this case would be a search field that either shows the results in a popup/dropdown, similar to AutoCompleteTextField¹ (which might more fittingly be named TextFieldWithSuggestions) but not accepting free text input or a kind of search field that expands into a (full-screen) search screen/dialog. The latter might be difficult to implement.

  2. Fields: On the one hand, you ask for the doctor specialty, on the other hand, the answers are what the doctors are. I.e. when the question is phrased that way, you'd expect the answer to be "neurology", not "neurologist". So, without adding any functionality, one could just rephrase the question. However, if a doctor's office has multiple specialties, this breaks down somewhat, so actually asking for the specialty would be better. This however would require the osmfeatures library to also add support for fields, including translations.


¹ Don't ask me why I used a Popup rather than a DropdownMenu because I don't remember; if you find out, maybe add a code comment; maybe something to do with that the DropdownMenu robs the text field of its focus?

@Helium314

Copy link
Copy Markdown
Collaborator

Don't ask me why I used a Popup rather than a DropdownMenu because I don't remember; if you find out, maybe add a code comment; maybe something to do with that the DropdownMenu robs the text field of its focus?

I don't remember exactly what it was, but I was playing with the AutoCompleteTextField when you had it in a PR (with ExposedDropdownMenuBox) and didn't get it to behave like an acceptable replacement for the Android AutoCompleteTextView.

@paulklie maybe you want to look at the SCEE implementation of this, I think the form was originally added by @matkoniecz.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new quest accepted new quest proposal (if marked as blocked, it may require upstream work first)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

New Quest: Speciality of medical practitioners

3 participants