Fix ScreenshotNumberReference number centering#3330
Open
mariekirsch wants to merge 1 commit into
Open
Conversation
Replace inline-block + padding/text-align hack with flexbox centering so the number renders centered regardless of font metrics.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
👋 Thank you so much for contributing to the Strapi documentation! Our team is currently away and won't be able to review your pull request right away. Rest assured we'll get to it as soon as we're back. Thanks a lot for your patience! 🙏 |
github-actions
Bot
added
internal
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The number badge used
inline-blockwithtextAlign/paddingto fake centering, which left the digit slightly off-center depending on font metrics.Switched to flexbox (
inline-flex+alignItems/justifyContent) for reliable vertical and horizontal centering.