Skip to content

(Closes #868) implement support for kernels with field arguments that specify nlayers/ndata - #3510

Open
arporter wants to merge 32 commits into
masterfrom
868_implement_nlayers_ndata
Open

(Closes #868) implement support for kernels with field arguments that specify nlayers/ndata#3510
arporter wants to merge 32 commits into
masterfrom
868_implement_nlayers_ndata

Conversation

@arporter

Copy link
Copy Markdown
Member

No description provided.

@arporter
arporter marked this pull request as draft July 29, 2026 10:56
@codecov

codecov Bot commented Jul 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (d9515d0) to head (9394da7).

Additional details and impacted files
@@            Coverage Diff             @@
##            master     #3510    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          399       399            
  Lines        56094     56196   +102     
==========================================
+ Hits         56094     56196   +102     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@arporter arporter added in progress LFRic Issue relates to the LFRic domain labels Jul 30, 2026
@arporter arporter self-assigned this Jul 30, 2026
@arporter

arporter commented Aug 7, 2026

Copy link
Copy Markdown
Member Author

This is very close to being ready. I need to finish doing a 'self review' and deal with the various TODOs, esp. where I'm using LFRicTypes("MeshHeightDataSymbol") for ndata.

@arporter
arporter deployed to integration August 26, 2026 08:54 — with GitHub Actions Active
@arporter
arporter marked this pull request as ready for review August 26, 2026 08:58
@arporter

Copy link
Copy Markdown
Member Author

This is ready for a first review now. It's slightly bigger (in terms of files touched) than I would like because I realised that at some point during the last PR, I mixed 'nlevels' with 'nlayers'. I've gone through and fixed this so that we only use 'nlayers' now. I've also altered the naming used for all nlayers arguments and that modified a bunch of tests too.

@arporter

Copy link
Copy Markdown
Member Author

ITs were all green. @stevemullerworth and @christophermaynard it would be good if someone at the MO could also test this branch out to check that I haven't missed anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

LFRic Issue relates to the LFRic domain ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant