Add macOS Intel build and fix mac code signing via jpackage - #65
Merged
Conversation
GitHub only offers Apple Silicon macOS runners for standard builds, so
add a macos-26-intel matrix entry to package.yml to also produce an
x64 build, alongside the existing arm64 one.
Switch the mac packaging profile from fvarrui/javapackager's mac
bundler to the JDK's own jpackage. javapackager's mac launcher
(universalJavaApplicationStub) is a shell script, not a Mach-O binary,
so rcodesign can't sign the resulting bundle ("Invalid magic number").
jpackage produces a real compiled launcher that both codesign and
rcodesign can sign correctly.
jpackage's runtime bundle also trips a known jpackage quirk (OpenJDK
JDK-8237490): Contents/runtime/Contents/Info.plist declares
libjli.dylib as CFBundleExecutable, causing it to be signed twice
(once as a nested bundle's main executable, once generically) which
notarization rejects. Strip CFBundleExecutable from that plist before
signing so libjli.dylib is only signed once.
garaimanoj
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
macos-26-intelmatrix entry topackage.ymlso the release pipeline builds both Apple Silicon (arm64) and Intel (x64) macOS artifacts, alongside the existing Windows/Linux builds.fvarrui/javapackager's mac bundler to the JDK's ownjpackage(newpackage-macMaven profile, auto-activated on macOS): javapackager's launcher script isn't a Mach-O binary, sorcodesigncouldn't sign it ("Invalid magic number").CFBundleExecutablefromContents/runtime/Contents/Info.plistbefore signing, working around a known jpackage quirk (OpenJDK JDK-8237490) wherelibjli.dylibotherwise gets signed twice and notarization rejects it.Test plan
Package Multiplatform Installersworkflow (workflow_dispatch, test mode) and confirm bothCertWizard-Mac-ARM64-APPandCertWizard-Mac-x64-APPartifacts build and sign successfully..appwithrcodesignsuccessfully.