ποΈ Add 2019 meeting notes - #2782
Conversation
Co-authored-by: Codex Web <noreply@openai.com>
There was a problem hiding this comment.
Pull request overview
Adds ten 2019 meeting archives to the meetings collection, including historical protocol discussions and one Meridian recording.
Changes:
- Adds 2019 meeting summaries and proposal tags.
- Registers Johnny Goodnow as an author.
- Updates generated meeting, author, tag, and pagination routes.
Recommendation: NEEDS-CHANGES β Correct proposal formatting/titles, missing CAP-6 tagging, and inaccurate metadata.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 13 comments.
Show a summary per file
| File | Description |
|---|---|
routes.txt |
Adds generated meeting and taxonomy routes. |
meetings/authors.yml |
Adds the meeting-note author profile. |
meetings/2019-01-24.mdx |
Archives January protocol discussions. |
meetings/2019-03-07.mdx |
Summarizes protocol priorities and proposals. |
meetings/2019-03-14.mdx |
Documents trustline and fee discussions. |
meetings/2019-03-21.mdx |
Covers authorization, fees, and order books. |
meetings/2019-03-28.mdx |
Records CAP and multisig discussions. |
meetings/2019-04-04.mdx |
Documents mergeable-trustline proposals. |
meetings/2019-06-13.mdx |
Summarizes precondition and fee-bump work. |
meetings/2019-06-27.mdx |
Details payment and precondition proposals. |
meetings/2019-07-25.mdx |
Records several CAP decisions. |
meetings/2019-11-04.mdx |
Embeds and summarizes a Meridian address. |
Suppressed comments (7)
meetings/2019-01-24.mdx:22
- The proposal names in this page are displayed with zero-padding (for example,
CAP-0005), contrary to the repository rule inCONTRIBUTING.md:85requiringCAP-5/SEP-13in prose while retaining padded canonical filenames in URLs. Please update all displayed CAP/SEP references on this page; the affected text includes lines 22β31, 45β48, 54, 59, and 63β64.
- [CAP-0005](https://github.com/stellar/stellar-protocol/blob/master/core/cap-0005.md) & [CAP-0006](https://github.com/stellar/stellar-protocol/blob/master/core/cap-0006.md) - moving to approval.
meetings/2019-03-07.mdx:75
- This labels CAP-15 as βBump Fee Transactions,β but the linked canonical proposal's title is βFee-Bump Transactions.β Use the canonical title consistently so readers can identify the proposal unambiguously.
- [CAP-0015](https://github.com/stellar/stellar-protocol/blob/master/core/cap-0015.md) - Bump Fee Transactions (OrbitLens)
meetings/2019-03-28.mdx:25
- βBump Fee Extensionβ is not the linked CAP-15 title; the canonical proposal is βFee-Bump Transactions.β Use the canonical title consistently so readers can identify the proposal unambiguously.
- [CAP-0015](https://github.com/stellar/stellar-protocol/blob/master/core/cap-0015.md) (Bump Fee Extension): Modified to utilize [CAP-0019](https://github.com/stellar/stellar-protocol/blob/master/core/cap-0019.md). Goal is to bring it to a vote, or enumerate what is needed to make it pass.
meetings/2019-03-14.mdx:34
- These descriptions are not the canonical proposal titles. The linked specifications call SEP-17 βIssuer account funding protocol (CAP-13 Based)β and SEP-16 βAccount Transfer Permissionless Payment Protocol (atp3).β Please use those titles so the historical notes identify the proposals accurately.
- [SEP-0017](https://github.com/stellar/stellar-protocol/blob/master/ecosystem/sep-0017.md): Deposit & transfer of assets using [CAP-0013](https://github.com/stellar/stellar-protocol/blob/master/core/cap-0013.md)
- [SEP-0016](https://github.com/stellar/stellar-protocol/blob/master/ecosystem/sep-0016.md): Deposit & transfer of assets using deterministic accounts
meetings/2019-06-27.mdx:22
- The canonical CAP-23 title is βTwo-Part Payments with ClaimableBalanceEntry,β not βTwo-Part Payments with BalanceEntry.β Because the body also uses names from an earlier draft, clarify the historical terminology while giving the linked proposal its canonical title.
- [CAP-0023](https://github.com/stellar/stellar-protocol/blob/master/core/cap-0023.md) - _Two-Part Payments with BalanceEntry_
meetings/2019-07-25.mdx:18
- βPath Payment w/Fixed Amountβ is not CAP-24's canonical title. The linked proposal is titled βMake PathPayment Symmetricalβ; use that title here.
- [CAP-0024](https://github.com/stellar/stellar-protocol/blob/master/core/cap-0024.md) - Path Payment w/Fixed Amount
meetings/2019-07-25.mdx:24
- The CAP-25 label is not its canonical title: the linked proposal is βRemove Bucket Shadowing,β not βShadow Bucket Removal.β Use the canonical proposal titles in this summary.
- [CAP-0021](https://github.com/stellar/stellar-protocol/blob/master/core/cap-0021.md), [CAP-0022](https://github.com/stellar/stellar-protocol/blob/master/core/cap-0022.md), [CAP-0025](https://github.com/stellar/stellar-protocol/blob/master/core/cap-0025.md) - Preconditions, Invalid Transaction Effects, Shadow Bucket Removal
π‘ Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Use unpadded proposal identifiers in meeting prose while preserving canonical padded filenames in URLs. Co-authored-by: Codex <noreply@openai.com>
Add CAP-6 discovery metadata, use the canonical CAP-15 title, and record the generated tag route. Co-authored-by: Codex <noreply@openai.com>
Pin the CAP-7 draft to its final historical revision and use the canonical SEP-16 title. Co-authored-by: Codex <noreply@openai.com>
|
There are some historic CAP title wordings maintained verbatim from the actual notes archive because they carry the precedence historical framing of the proposals while they were WIPs. " |
Correct the proper-name capitalization in the Meridian meeting summary. Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
for #1087