fix(api): validate GPT-6 Astra reasoning capabilities - #449
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
Codex review: needs real behavior proof before merge. Reviewed September 7, 2026, 7:57 PM ET / 23:57 UTC. ClawSweeper reviewWhat this changesAdds GPT-6 Astra API configuration and reasoning validation, updates help and documentation, and rejects unsupported browser selection while preserving current/ignore strategies. Merge readiness⛔ Blocked before merge - 3 items remain Keep open: the API support remains useful and is not implemented on main. The earlier browser-strategy finding is resolved, and official documentation supports the model contract, but real Responses/Pro completion remains unproven. Repository policy also prohibits automatic closure. Priority: P2 Review scores
Verification
How this fits togetherOracle turns CLI or MCP requests into model consultations. API requests pass through model configuration and reasoning validation before provider dispatch; browser requests use a separate model-selection path. flowchart TD
A[CLI or MCP request] --> B{API or browser}
B -->|API| C[Model configuration and overrides]
C --> D[Validate reasoning options]
D --> E[Responses request and completion]
B -->|Browser| F{Selection strategy}
F -->|Select Astra| G[Explain unsupported selection]
F -->|Current or ignore| H[Keep active ChatGPT model]
Before merge
Agent review detailsSecurityNone. Review metrics
Merge-risk optionsMaintainer options:
Technical reviewBest possible solution: Keep Astra capability checks within the existing API pipeline, preserve browser strategy preferences, and establish real completion and configuration compatibility before landing. Do we have a high-confidence way to reproduce the issue? Not applicable as an established-behavior bug: this adds model-specific support. Source inspection confirms main rejects explicit Astra reasoning options; no live inference was attempted. Is this the best way to solve the issue? Yes, the implementation extends the existing model registry and validation path without adding a competing provider adapter; its runtime claims still need real evidence. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against fe2c8d990562. LabelsLabel justifications:
EvidenceWhat I checked:
Likely related people:
Rank-up movesOptional improvements that raise the rating; they are not merge blockers.
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
HistoryReview history (2 earlier review cycles) |
Preserve browser-only Pro aliases through CLI engine discovery, retain model-specific API capabilities, and verify localized Latest and effort controls. Combine the compatible work from steipete#448, steipete#449, and steipete#465; release notes are deferred to the final notes PR.
|
Landed through #465, which consolidates this change with the related model work and keeps your contributor credit in the squash commit and changelog. Thank you. |
Consolidate API capability validation and Latest browser selection from #449 and #448. Validate model-specific reasoning efforts, reject invalid saved defaults, recognize localized picker controls, and preserve browser-only aliases during engine discovery. Keep the default model unchanged. Real standard/Pro API calls, Latest/High and Latest/Pro browser requests, and a controlled Sol-to-Latest transition passed. Thanks @kiyo-e for the browser work incorporated into this PR. Co-authored-by: FND <fndevve@proton.me> Co-authored-by: oraclexing <xing_z@hotmail.com> Co-authored-by: nummy <6960749+malvarezcastillo@users.noreply.github.com>
Summary
Explicit Astra API reasoning options currently fail Oracle's GPT-5.6-only validation. Register the exact
gpt-6-astraAPI model and validate its effective reasoning effort against a separate capability set:low,medium,high,xhigh, andmaxare accepted;noneis rejected before inference, including when supplied by a model override. An explicit supported effort can replace an invalid configured default. GPT-5.6 retains its existingnonesupport.Responses
standard/promode retains the existing route checks and Pro lifecycle defaults. Astra usesweb_searchand a conservative 272K default input budget at the standard-rate boundary; the documentation distinguishes that budget from maximum context and explains cost-estimate limits.Browser boundary
This remains API-focused and does not incorporate #448's browser implementation. Until that browser support lands, explicit Astra selection fails before browser launch. Existing
currentandignorestrategies remain usable without claiming the active ChatGPT model is Astra. No installed MCP deployment or default model is changed.Current validation
Updated onto main
fe2c8d9905624c71a406eb006bc1ab7cc3735744(0.19.0) at head9434f68dd8a1d10b50ad713621beec6eec09f796. The merge resolves the changelog conflict while preserving the released main entries and placing this feature under Unreleased.pnpm run checkandpnpm run build: passed on Windows / Node 24.11.1.pnpm vitest run --maxWorkers 4: 2,240 passed, 53 skipped; 176 test files passed, 18 skipped.gpt-6-astrawith Pro/max. Browser dry-runs succeed forcurrentandignore; unsupportedselectexits 1 before browser launch.api.openai.com, missingOPENAI_API_KEY, and no ready inference route. No real API request was sent.These are local tests and dry-runs. They do not prove live Astra inference, Pro completion, or current ChatGPT account availability.
Remaining proof gate
Real Responses/Pro completion remains outstanding because no API credential is available in the validation environment. Browser subscription runs are not API proof. Maintainers or a credentialed contributor still need to supply real inference evidence and fresh/existing-configuration runtime coverage before treating that gate as satisfied.
Official sources were successfully retrieved again on September 8, 2026: the Astra model page confirms the supported efforts, $10/$50 per-million input/output token rates, and higher pricing above 272K input tokens; the model guide confirms no
noneeffort and continued pro-mode support. This resolves the documentation-access uncertainty from the previous review, not the live-inference gap.