fix(browser): recognize Chinese Deep Research controls - #428
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
Codex review: needs maintainer review before merge. Reviewed September 7, 2026, 9:53 PM ET / September 8, 2026, 01:53 UTC. ClawSweeper reviewWhat this changesRecognizes Simplified Chinese Deep Research menu, selected-tool, and add-files controls, preserves compact English labels, and adds activation tests and documentation. Merge readiness✅ Ready for maintainer review This PR remains useful and has no identified blocking defect. Current main lacks Chinese activation matching, and the maintainer’s signed-in evidence covers the changed behavior. The earlier changelog concern is resolved. Priority: P2 Review scores
Verification
How this fits togetherOracle’s browser engine selects ChatGPT’s Deep Research tool before submitting a research prompt. This change updates how it recognizes the menu entry and verifies the selected tool. flowchart LR
A[Research request] --> B[Open composer tools]
B --> C[Match English or Chinese label]
C --> D[Select Deep Research]
D --> E[Verify selected tool]
E --> F[Submit research prompt]
Before mergeNone. Agent review detailsSecurityNone. Review metrics
Technical reviewBest possible solution: Keep localized recognition in the existing activation path, preserving English matching and selected-tool verification without changing user settings. Do we have a high-confidence way to reproduce the issue? Yes, from source: current main cannot match the documented Chinese menu and pill labels. This review did not execute a failing main run. Is this the best way to solve the issue? Yes. Extending the existing label matching is a focused repair, and the signed-in observations exercise activation and submission through the production CLI. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against fe2c8d990562. LabelsLabel justifications:
EvidenceWhat I checked:
Likely related people:
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
HistoryReview history (6 earlier review cycles)
|
bb5ca9a to
c7fe620
Compare
|
Rebased onto current @clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. |
|
Added real signed-in Simplified Chinese proof on exact head @clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. |
|
Maintainer proof for
|
Recognize Simplified Chinese Deep Research menu labels, the selected-tool pill, and the add-files fallback. Preserve the existing compact English
DeepResearchlabel and keep selection scoped to the visible popover so a neighboring connector is not selected.Maintainer repair preserves the contributor history and moves release-note ownership to the final notes PR. The implementation has no CHANGELOG.md delta against main.
Validation at
ce5ca1c14aa8e1ef202905902315210ff96c8c5d:zh-CNChatGPT page selected深度研究, submitted one public-source research prompt, and reached the research-plan/researching state. The original Auto-detect language preference was restored.Deferred changelog: