chore(ci): replace SourceKnight with setup-sp - #20
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the SourceKnight-based build (
maxime1907/action-sourceknight@v1) with a native GitHub Actions CI workflow, following the org-wide migration pattern (usingsrcdslab/sm-plugin-AdminRoomas the validated reference).Plugin targets
addons/sourcemod/scripting/ForceInputs.spDependencies
https://sm.alliedmods.net/smdrop/1.11/sourcemod-1.11.0-git6934-linux.tar.gz(tar, not a git dependency)/addons->/addonsNo
type: gitdependencies were declared insourceknight.yaml; the only dependency was the SourceMod tarball itself, which is now provided byrumblefrog/setup-sp(pinned to SourceMod 1.12.x per migration policy) instead of the previously pinned 1.11.0-git6934 tarball.Changes
.github/workflows/ci.ymlmodeled on the AdminRoom reference: build job usingrumblefrog/setup-sp@v1.3.1(SourceMod 1.12.x), tag job, and release job (with the correctedactions/checkout@v7first step intagand the combinedalways() && ...condition inrelease).sourceknight.yaml..github/copilot-instructions.mdto remove/replace SourceKnight-specific build instructions with the native spcomp/GitHub Actions equivalents.addons/sourcemod/plugins/*.smxinto the package, since the repo contains noconfigs/,translations/, or other extra asset directories.Not locally validated
This migration was performed without cloning dependencies or compiling locally, per the lightweight migration process. GitHub Actions CI on this PR is the source of truth for build correctness.
Manual verification needed
<sourcemod>and<sdktools>, both provided by the base SourceMod install viarumblefrog/setup-sp, with no external dependencies to verify.